Template based search UI

smddzcy commented 6 years ago

About

Related Issues: #180
Related Pull Requests: #200

Implemented the frontend of the template-based search, i.e. our advanced search feature. This PR contains some other minor changes as well.

Changes

Implement the frontend of dynamic template-based search.
Add a filter called jsonify to convert a Django object to a JSON string.
Add links to group names in recommended posts for easy navigation.

Visuals

adv-search

Edit:

Advanced search is a navbar item now:
Data template selectbox options now include the group names, because groups can have templates with the same name:

Testing

Log in to our web app.
Focus on the search input in the navbar and click Enter - it should redirect you to the advanced search page.
Select a data template and add some constraints.
Click the Search button - the page should display a loading icon while making the request, and then display your results. Check the correctness of the results by making the same request with Postman or some other tool.

smddzcy commented 6 years ago

It's probably the ugliest piece of code I've ever written, but it works. Please review 🤓

ThoAppelsin commented 6 years ago

A review, off the top of my head: We should have a dedicated button for this feature, even if it is just a text with link. It is a great feature, and just now, it is ~~very~~ somewhat (just saw the text guiding the user to press enter on the blank search box) hidden.

smddzcy commented 6 years ago

Sounds cool but where to put that button? 🤔

On 26 Dec 2017, at 12:16, Utkan Gezer notifications@github.com wrote:

A review, off the top of my head: We should have a dedicated button for this feature, even if it is just a text with link. It is a great feature, and just now, it is very hidden.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

ThoAppelsin commented 6 years ago

My original thought was to put "Advanced Search" text to the left hand side of the box. We can also put something to the right hand side of the usual search button, maybe a very advanced looking magnifying-glass could do.

smddzcy commented 6 years ago

@ThoAppelsin:

My original thought was to put "Advanced Search" text to the left hand side of the box. We can also put something to the right hand side of the usual search button, maybe a very advanced looking magnifying-glass could do.

I agree; advanced search is a navbar item now 👌

ThoAppelsin commented 6 years ago

Bugs fixed. Seems all good to me now. With or without the bugs, it's good work.

bounswe / bounswe2017group5