search

bounswe / bounswe2023group6

10 stars 0 forks source link

[Mobile] Lfg comment section #618

Closed erkamkavak closed 10 months ago

erkamkavak commented 10 months ago

Following changes are made in this pr:

umutdmr commented 10 months ago

I found two issues related to this task:

If you worked with mock data, then it is completed.

erkamkavak commented 10 months ago

I found two issues related to this task:

  • A user can upvote and downvote the same comment at the same time.
  • Reply section can't be open.

If you worked with mock data, then it is completed.

I solved the second problem, thanks for the correction. For the first problem, it was the same for post page; maybe we can fix this if we have time later.

umutdmr commented 10 months ago

I wrote a comment as "deneme", then reply this comment. Here is the results:

Screenshot 2023-12-23 at 20 41 05

here is the looking:

Screenshot 2023-12-23 at 20 41 28

this looks wrong, it has to be fixed.

erkamkavak commented 10 months ago

I wrote a comment as "deneme", then reply this comment. Here is the results: Screenshot 2023-12-23 at 20 41 05

here is the looking: Screenshot 2023-12-23 at 20 41 28

this looks wrong, it has to be fixed.

This is because backend connections for lfg are not completed yet. Creating comment for lfg is not supported yet and this error is related to this.

ohbahadiroglu commented 10 months ago

I wrote a comment as "deneme", then reply this comment. Here is the results: Screenshot 2023-12-23 at 20 41 05 here is the looking: Screenshot 2023-12-23 at 20 41 28 this looks wrong, it has to be fixed.

This is because backend connections for lfg are not completed yet. Creating comment for lfg is not supported yet and this error is related to this.

backend for lfg section implemented yesterday. now you can solve those issues.

umutdmr commented 10 months ago

I am testing @ohbahadiroglu

umutdmr commented 10 months ago

There is again the same issue, but if it is related to the backend, then it is done. @erkamkavak

umutdmr commented 10 months ago

There is another issue, when i close the lfg page after commenting, if i go to the same lfg page again the comment is disappeared.

erkamkavak commented 10 months ago

There is again the same issue, but if it is related to the backend, then it is done. @erkamkavak

No actually it is not related to backend. I haven't done the backend connections yet, I will do them in a different pr. We can close this if there is no issue on the view of the page.

umutdmr commented 10 months ago

Okay, if you using mock data right now, then this pr is done. Good job!