bounswe / bounswe2024group6

6 stars 0 forks source link

feat(mobile): Tab Layout, Profile Page Design, Quiz Card Component #474

Closed YavizGuldalf closed 2 weeks ago

YavizGuldalf commented 3 weeks ago

This PR includes a plethora of changes related to the mobile app. You can find a full list of changes below:

Fixes the Issues #466 and #467.

aoengin commented 3 weeks ago

As the reviewer of these two issues, I've added some comments on the code.

Screenshot 2024-11-04 at 01 16 47 Screenshot 2024-11-04 at 01 16 15 Screenshot 2024-11-04 at 01 26 12 Screenshot 2024-11-04 at 01 36 06
YavizGuldalf commented 2 weeks ago

@aoengin, I have made the changes you requested. Specifically,

You can find screenshots of the changed pages below:

The About Me section expands indefinitely when a user types, making the button and other sections unreachable after a certain point. The edit profile page having a resizable 'About Me' input box was intentional. That page is scrollable so every item can be viewed, as you can see in the screenshots.

Can you please review these changes?

aoengin commented 2 weeks ago

Thanks for the changes.

Screenshot 2024-11-09 at 11 52 54

You can change the text color to white.

That page is scrollable so every item can be viewed, as you can see in the screenshots.

It's unnecessary and does not appear professional. Please try entering an example description in the quiz creation settings.

YavizGuldalf commented 2 weeks ago

Thanks for the changes.

Screenshot 2024-11-09 at 11 52 54

You can change the text color to white.

That page is scrollable so every item can be viewed, as you can see in the screenshots.

It's unnecessary and does not appear professional. Please try entering an example description in the quiz creation settings.

Okay, the 'Edit Profile' button's style has been changed to be the same as the ones in the edit profile page. Also, the 'About Me' section of the edit profile page now has a fixed height and a character limit (120 chars). I have also added a 40 char limit to the name field and fixed its height

aoengin commented 2 weeks ago

I guess it's okay to have a character limit, but why didn’t you make it the same as the description part in the quiz settings? I already suggested that.

Please try entering an example description in the quiz creation settings.

YavizGuldalf commented 2 weeks ago

I guess it's okay to have a character limit, but why didn’t you make it the same as the description part in the quiz settings? I already suggested that.

The main reason why I put a character limit was so the profile page wouldn't look weird if the user tried to enter a really really long "About Me". Without a limit they could write so many characters that it would be unreasonable to display it in their profile. Of course, 120 may not be the appropriate number for the 'About Me' section (it can be lower or higher, it's up for debate), but I think having a character limit on almost all of our inputs is good practice.

Please try entering an example description in the quiz creation settings.

I don't think I quite understand what you mean by this. The "Description" input part in the quizCreationSettings page looks like the following:

<TextInput
  style={[styles.input, styles.descriptionInput]}
  placeholder="Enter quiz description"
  value={quizDescription}
  onChangeText={setQuizDescription}
  multiline={true}
 />

...

styles = StyleSheet.create({
  input: {
    backgroundColor: '#E8E8E8',
    borderRadius: 10,
    padding: 10,
    fontSize: 16,
    marginBottom: 20,
  },
  descriptionInput: {
    height: 100, 
    textAlignVertical: 'top',
  },
...

Do you want me to use the same style props with multiline set to True?