search

bounswe / bounswe2024group6

6 stars 0 forks source link

feat(mobile): Search Page #503

Closed YavizGuldalf closed 3 days ago

YavizGuldalf commented 5 days ago

Fixes #465 This PR includes the designs for the search page. This search page is designed to be a general search for the app, showing search results for users, quizzes and forums. This is up-for-debate though, as we already have search functionality in the Quiz and Forum pages separately. Still, having a general place for searching may be nice.

I have also added sorting and filtering options. You can sort by newest or most liked, and you can use the filters to constrain the search to certain content types and tags. The search functionality was left entirely to the backend. I have integrated the page's design with quizCard and userCard components, but forum post and comment cards have not been merged to main yet and therefore they have placeholders instead. You can find example screenshot below.

aoengin commented 4 days ago
Screenshot 2024-11-18 at 07 17 53

Can you fix the visual bug in the tags? - tested with Medium Phone

It would also be good if the 'Sort By' feature had an option to clear the selected choice.

YavizGuldalf commented 3 days ago

@aoengin, I have added a few commits that should fix the issues you mentioned. I don't know the exact model of the virtual device you are using to simulate the program but I tested this new version on a medium sized phone (Pixel 4) and the results look like the following:

I have also added the option to clear the 'Sort by' feature:

Can you please review these changes again?

aoengin commented 3 days ago

Dividing the options into "cards" would be a good idea since there are no borders between the choices currently. However, I'll merge it for now and we can improve the UI later.