search

bounswe / bounswe2024group9

9 stars 1 forks source link

[Kristina, Mutti] About wikidata results #268

Closed Mutti499 closed 1 week ago

Mutti499 commented 1 week ago

I had a little problem when navigating in the web frontend. On the feed page, I tried to reach the popular tags shown in the image: image

When I tried to go JavaScript, there was no problem: image

However, when I tried to reach the Python page, I got an undefined error from the frontend. When I investigated that, I noticed the frontend not getting what it was wanted in field 'inception date'. I fixed the crash problem in the front end; however, I think there may be a bigger issue. On a well-known Python page, we only have a little information.

image

I tried to see what is returning with Postman and saw the following for Javascript and Python: Javascript: image

Python: image

There is missing information, and it is causing problems on the frontend. Can I get some information about how we are planning to improve that part, if we have any? If we may find something to do, like setting the fields while returning from the backend in order to prevent crashes like that.

Can we discuss that? I am calling you because you have a lot more knowledge than I do. @ceylingebes @kristinatrajkovski

ceylingebes commented 1 week ago

Of course. First solution that comes into my mind is filling out some popular topics such as Python manually but this wouldn’t be feasible. Maybe if wikidata lacks some fields -such as inception date- and there is no way to gather this info from wikidata, we can disable these fields for those languages in question. First solution would provide us a more detailed information about topics but requires more time for manual entries and determining which languages are affected, secoms solution would be more logical in programming-wise but it could result in some pages having a very little info. We can gather sometime and decide how to proceed if it’s suitable or discuss on here.

kristinatrajkovski commented 1 week ago

There will always be results with null values so we need to make sure to handle such cases when connecting to front end, @ceylingebes maybe you can help with that by adding some null checks to our fields before displaying them in the front.

For python specifically, great catch @Mutti499, I have investigated the issue and added a few more topics to search in in PR #257 . Now we have much more extensive results when searching programming languages and computer science concepts, including Python.

Mutti499 commented 1 week ago

Nice job on that! I already fixed the frontend crash problem like I mentioned so there wont a problem also. I will review your pr and close that with our issue