search

bounswe / bounswe2024group9

9 stars 1 forks source link

Web/code execution #295

Closed FatihAkgoz closed 6 days ago

FatihAkgoz commented 1 week ago

Changes in question detail pages are in this pr.

Mutti499 commented 1 week ago

This PR is changing a lot of code in backend and needs a lot of investigation in order to prevent overwrites. I will take one more look after the PR is merged.

serhan-cakmak commented 1 week ago

@Mutti499 I modified the endpoint as you requested!

Mutti499 commented 1 week ago

image I am unable to understand is it our question page

serhan-cakmak commented 1 week ago

image I am unable to understand is it our question page

We happen to enhance the backend-frontend connection in this pr. Makeups can be made by the front side, I am creating the issue rn.

In the example you gave user created the question without code snippet, and apparently the rendered page is vulnerable for that. You can observe this example for you to understand the current situtation.

image

Mutti499 commented 1 week ago

Yea the page seems good. Can you solve the merge conflicts so that I can merge the PR? @serhan-cakmak @FatihAkgoz

serhan-cakmak commented 1 week ago

I reviewed the merge conflicts, but I found the one in feed.js too complicated since I didn't make any changes to that file. However, it shouldn't be an issue for you to resolve, @FatihAkgoz. If you need any help, just let me know.

FatihAkgoz commented 6 days ago

I took a reverse merge and fixed the conflicts.