bourgeoisor / xivtodo

Dashboards, tailored checklists and tools for Final Fantasy XIV.
https://xivtodo.com
GNU General Public License v3.0
124 stars 18 forks source link

Elemental and bozjan levels are sometime inverted #14

Closed bourgeoisor closed 2 years ago

bourgeoisor commented 2 years ago

A couple profiles seems to be displaying an issue where the elemental and bozjan levels are inverted or unavailable. I'm not quite sure if this issue comes from godestone, lodestone-css-selectors, or something else, but XIVAPI returns the correct values (whereas my instance of godestone doesn't).

This is an example where it's working as expected:

// https://na.finalfantasyxiv.com/lodestone/character/32741501/class_job/

"ClassJobBozjan": {
    "Level": 25,
    "Mettle": 0,
    "Name": "Resistance Rank"
},
"ClassJobElemental": {
    "ExpLevel": 5988,
    "ExpLevelMax": 157568,
    "ExpLevelTogo": 151580,
    "Level": 17,
    "Name": "Elemental Level"
},

This is one of those very few cases where for some reason it doesn't behave quite right (notice the Eureka level overwrites the Bozja level (which for this character should show 25):

// https://na.finalfantasyxiv.com/lodestone/character/25865622/class_job/

"ClassJobBozjan": {
    "Level": 41,
    "Mettle": 9338806,
    "Name": "Elemental Level"
},
"ClassJobElemental": {
    "ExpLevel": 0,
    "ExpLevelMax": 0,
    "ExpLevelTogo": 0,
    "Level": 0,
    "Name": ""
},
bourgeoisor commented 2 years ago

I disabled those levels from the Profile in the meantime: https://github.com/bourgeoisor/xivtodo/commit/4ac32a18b6bcd26f3c462e83e5bc6810ce0273e6

bourgeoisor commented 2 years ago

Since this fix: https://github.com/xivapi/godestone/commit/66e12122a34ab7060d5c26b1c4ba1a8f3f278faa It seems to work fine again. I've reverted the removal: https://github.com/bourgeoisor/xivtodo/commit/bfc2525fc6762b2db8a7f14f9605f405cc5f4004