The initial design of exercise.py is not very DRY (i.e. Don't Repeat Yourself), as many of the variables are 'hard-coded' based on the experiment (e.g. count_rate_downscan and count_rate_upscan instead of just count_rate). Since this code should be able to incorporate other experiments other than the DownScan and UpScan, the experiment itself should be variable, or perhaps the IrradianceExercise class should be reworked to have the exercise be an attribute.
The initial design of
exercise.py
is not very DRY (i.e. Don't Repeat Yourself), as many of the variables are 'hard-coded' based on the experiment (e.g.count_rate_downscan
andcount_rate_upscan
instead of justcount_rate
). Since this code should be able to incorporate other experiments other than the DownScan and UpScan, the experiment itself should be variable, or perhaps theIrradianceExercise
class should be reworked to have theexercise
be an attribute.