search

boutbagha / and-bookworm

Automatically exported from code.google.com/p/and-bookworm
0 stars 0 forks source link

Flipping phone orientation leads to repeat online search #41

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Scan book,
online check retrieves info and I could add book to library.
If I flip the phone from landscape to portrait or vice versa, bookworm
checks the web again instead of just adjusting the orientation.

Original issue reported on code.google.com by afx...@gmail.com on 9 May 2010 at 10:00

GoogleCodeExporter commented 8 years ago 
If the search is not yet complete it does the search again, if it is complete 
it does 
not. This is an artifact of how orientation changes work on Android because the 
Activity is completely re-created. If the data is there, I save it and don't do 
the 
search again, but if the search is not completed it's not there to save. 

Are you sure this is happening after results are shown? 

There are some other tricks I can use to not re-start the search even if the 
results 
are not back yet, but it's pretty complicated and for the current version I 
didn't 
think it was a big problem if it just re-searches if results aren't in yet. 

Thoughts?

Original comment by charlie....@gmail.com on 10 May 2010 at 1:28

GoogleCodeExporter commented 8 years ago 
Well, the button to accept the book is already shown when this happens.
Not a big deal if you only scan one or two books, but a bit time consuming on a 
few
hundred (I scanned >400 in the last week, mostly done by now, so not really a
pressing issue ;-)

Original comment by afx...@gmail.com on 10 May 2010 at 1:57

GoogleCodeExporter commented 8 years ago 
I'll keep this open and try to look at it more, not sure I understand it yet.

Original comment by charlie....@gmail.com on 15 May 2010 at 1:30

GoogleCodeExporter commented 8 years ago 
I understand this now. It's the BookEntryResult Activity that we are talking 
about 
here, after data is retrieved on the page that says "Add Book" if you flip, it 
makes 
request again. Shouldn't do that, easy fix.

Original comment by charlie....@gmail.com on 25 May 2010 at 5:32

GoogleCodeExporter commented 8 years ago

Original comment by charlie....@gmail.com on 1 Jun 2010 at 12:35