search

boutproject / BOUT-dev

BOUT++: Plasma fluid finite-difference simulation code in curvilinear coordinate systems
http://boutproject.github.io/
GNU Lesser General Public License v3.0
182 stars 95 forks source link

SUNDIALS v7 support (backport to v5) #2937

Closed ZedThree closed 2 months ago

ZedThree commented 3 months ago

Backport of #2896 and #2922 into v5.1.1

This drops support for SUNDIALS < v4, so maybe this means this release should be 5.2.0 rather than 5.1.1? Everything else is a pretty minor change though

dschwoerer commented 3 months ago

It seems < v4 was anyway not working, so making this more obvious is not a breaking change, but rather a bug fix, I would argue. https://github.com/boutproject/BOUT-dev/pull/2840

Needing a newer c++ might however a breaking change, justifying 5.2.0 ...

ZedThree commented 3 months ago

Ah, ok, I hadn't realised < v4 was broken. Ok, probably fine for 5.1.1 then. next is v6 and includes upgrading to C++17.

Looks like I should've attempted to compile this locally, there's some C++17 bits that need downgrading to 14

ZedThree commented 2 months ago

I think Fedora mirrors are maybe having some issues

dschwoerer commented 2 months ago

It seems just one of them is bad. We probably should set a higher minimum bandwidth for dnf, to pick a faster one. The default is quite low, as it should also work for poor mobile connections.

dschwoerer commented 2 months ago

Slow mirrors should be fixed by #2940