search

boutproject / BOUT-dev

BOUT++: Plasma fluid finite-difference simulation code in curvilinear coordinate systems
http://boutproject.github.io/
GNU Lesser General Public License v3.0
182 stars 95 forks source link

CMake compilation error with MPI_C and SUNDIALS #2945

Open mikekryjak opened 1 month ago

mikekryjak commented 1 month ago

The recent SUNDIALS update made it necessary to add the C language to the project line in the Hermes-3 cmake script (see https://github.com/bendudson/hermes-3/pull/233/commits/7407e35e146425f86756a2e7b5dd6b171832ff47). I'm leaving this here in case this information is useful to someone.

Steven-Roberts commented 1 month ago

Just seeing this issue now. Is this still the case after this PR was merged? In particular, with this change https://github.com/boutproject/BOUT-dev/pull/2922/files#diff-3c300e85313a4acb4aa412b9d561a30fd081396a05de144d624ceec30e387c5dR300

mikekryjak commented 1 month ago

Yes, we are using this commit: https://github.com/boutproject/BOUT-dev/commit/d7f88073f3ad707d624f8b9fed0a97a49596c542

You can see that the changes are there: https://github.com/boutproject/BOUT-dev/blob/d7f88073f3ad707d624f8b9fed0a97a49596c542/cmake/SetupBOUTThirdParty.cmake#L300-L301