search

boutproject / BOUT-dev

BOUT++: Plasma fluid finite-difference simulation code in curvilinear coordinate systems
http://boutproject.github.io/
GNU Lesser General Public License v3.0
182 stars 95 forks source link

CVODE mxorder setting no longer works #2946

Open mikekryjak opened 1 month ago

mikekryjak commented 1 month ago

I've noticed that CVODE won't stay on first order in some of my recent test runs. From @Steven-Roberts:

There's been two options to set the max order: cvode_max_order and mxorder. In some of the recent changes, I accidentally have mxorder going unused. A temporary fix is to switch to cvode_max_order. For a proper fix, some options are: Allow both options as it was before Allow one option and remove the unused other option so at least there will be an error when parsing the input file.

ZedThree commented 1 month ago

Ah, we probably want to restore the option in master/5.1.1, mark it as deprecated (not sure we actually have a way of doing this for input options), and then add it to the input upgrader when we remove it.

Steven-Roberts commented 1 month ago

I can make a PR fix Monday. Which should be deprecated? cvode_max_order or mxorder?

ZedThree commented 1 month ago

I think maybe deprecate mxorder and keep cvode_max_order?

To be honest, looking through the rest of the options, we don't have terribly consistent naming scheme -- another one for the to do list, sort out option names!

Steven-Roberts commented 1 month ago

Ok, sounds good. I'll get started on a fix