Deprecation of bout_error

[ZedThree]

All this does is throw a BoutException and call exit(1), so it should be trivial to just replace with a thrown exception everywhere.

[ZedThree]

Deprecated in 51d219e. To be removed in 5.0

[dschwoerer]

./examples/elm-pb/elm_pb.cxx:      bout_error("Aborting.\n");
./examples/non-local_1d/cubic_spline_local.cxx:  else bout_error("CubicSpline: direction is not valid");
./examples/non-local_1d/non-local_parallel.cxx:    bout_error("Trying to calculate the heat flux at CELL_YLOW while StaggerGrids=false is an error.");
./examples/non-local_1d/non-local_parallel.cxx:      bout_error("Could not open heatfluxcoeffs file");
./examples/non-local_1d/non-local_parallel.cxx: bout_error("reached end of heatfluxcoeffs file unexpectedly");
./examples/non-local_1d/non-local_parallel.cxx:      bout_error("Could not open heatfluxbc file");
./examples/non-local_1d/non-local_parallel.cxx: bout_error("reached end of heatfluxbc file unexpectedly");
./examples/non-local_1d/non-local_parallel.cxx:      bout_error("Could not open viscositycoeffs file");
./examples/non-local_1d/non-local_parallel.cxx: bout_error("reached end of viscositycoeffs file unexpectedly");
./examples/non-local_1d/non-local_parallel.cxx:      bout_error("Could not open viscositybc file");
./examples/non-local_1d/non-local_parallel.cxx: bout_error("reached end of viscositybc file unexpectedly");
./examples/non-local_1d/non-local_parallel.cxx:      bout_error("Could not open frictioncoeffs file");
./examples/non-local_1d/non-local_parallel.cxx: bout_error("reached end of frictioncoeffs file unexpectedly");
./examples/non-local_1d/non-local_parallel.cxx:      bout_error("Could not open frictionbc file");
./examples/non-local_1d/non-local_parallel.cxx: bout_error("reached end of frictionbc file unexpectedly");
./examples/non-local_1d/non-local_parallel.cxx:  if (mesh->UpXSplitIndex()!=0 || mesh->DownXSplitIndex()!=0) bout_error("This code cannot currently handle x-splitting of processors.");
./examples/non-local_1d/non-local_parallel.cxx:  if (mesh->UpXSplitIndex()!=0 || mesh->DownXSplitIndex()!=0) bout_error("This code cannot currently handle x-splitting of processors.");
./examples/non-local_1d/non-local_1d.cxx:    bout_error("Cannot calculate effective_alpha_e without non-local heat-flux");
./examples/non-local_1d/non-local_1d.cxx:    bout_error("FLUXLIMITER can only be defined if LOCALHEATFLUX is also defined");
./examples/d3d-129131/2fluid.cxx:    bout_error("ERROR: Invalid bkgd option\n");
./examples/d3d-129131/2fluid.cxx:    bout_error("ERROR: invalid option for iTe_dc\n");
./examples/d3d-119919/2fluid.cxx:    bout_error("ERROR: Invalid bkgd option\n");
./examples/d3d-119919/2fluid.cxx:    bout_error("ERROR: invalid option for iTe_dc\n");
./examples/6field-simple/elm_6f.cxx:      bout_error("Aborting.\n");
./examples/rb-tokamak/2fluid.cxx:    bout_error("ERROR: Invalid bkgd option\n");
./examples/rb-tokamak/2fluid.cxx:    bout_error("ERROR: invalid option for iTe_dc\n");
./include/globals.hxx:void DEPRECATED(bout_error(const char *str=NULL));
./src/bout++.cxx:void bout_error() {
./src/bout++.cxx:  bout_error(NULL);
./src/bout++.cxx:void bout_error(const char *str) {
./src/solver/impls/petsc-3.4/petsc-3.4.cxx:      if(n2Dvars() != 0) bout_error("PETSc solver can't handle 2D variables yet. Sorry\n");
./src/solver/impls/petsc-3.2/petsc-3.2.cxx:    if(n2Dvars() != 0) bout_error("PETSc 3.2 solver can't handle 2D variables yet. Sorry\n");
./src/solver/impls/petsc-3.5/petsc-3.5.cxx:      if(n2Dvars() != 0) bout_error("PETSc solver can't handle 2D variables yet. Sorry\n");
./src/solver/impls/petsc-3.1/petsc-3.1.cxx:      bout_error("PETSc solver can't handle 2D variables yet. Sorry\n");
./src/solver/impls/petsc/petsc.cxx:      if(n2Dvars() != 0) bout_error("PETSc solver can't handle 2D variables yet. Sorry\n");
./src/invert/parderiv/impls/simple/invert_parderiv_simple.cxx:        bout_error("Sorry; invertParSimple can't cope with open field lines yet\n");
./src/invert/parderiv/impls/simple/invert_parderiv_simple.cxx:        bout_error("ERROR: Crossed streams in invpar::cyclic_solve!\n");
./src/invert/laplace/impls/mumps/mumps_laplace.cxx:  if ( i!=mumps_struc.nz_loc ) bout_error("LaplaceMumps: matrix index error");
./src/invert/laplace/impls/mumps/mumps_laplace.cxx:  if ( i!=mumps_struc.nz_loc ) bout_error("LaplaceMumps: matrix index error");
./src/precon/jstruc.cxx:  bout_error("...now exiting to system...");

Still used plenty of times ...

[ZedThree]

These are all fixed. Only thing left to do is to actually remove it in 5.0

[d7919]

I think this has already been removed so can we close the issue?