laplacexz should exit when g13 \neq 0

[JensMadsen]

lalplacexz assumes that gxz = g13 = 0. Therefore, if g13 \neq 0 the code should exit. Perhaps we could allow the user to set a flag which specifically allowed using laplacexz with gxz \neq 0 ?

[d7919]

I think this is the sort of check that would be very useful to have and I'd be keen to have the ability to check consistency of assumptions and operators as widely as possible. To avoid introducing a large number of specialist flags we could consider introducing a new configure flag that switches between "rigorous" and "production" modes -- this way people can compile with rigorous and check that their model and setup is consistent and then if they need performance etc. they can switch to "production". Obviously this has quite a bit of overlap with --with-checks etc. but those tend to be checks of the numerics whilst here we're talking about the assumptions/physics.

[JensMadsen]

I agree. Lets NOT put a flag unless someone really needs it

[bendudson]

Perhaps a flag in the options like check_g13 which defaults to true. A user could explicitly disable the check if they wanted to.

Alternatively, someone could add the g13 tends to LaplaceXZ

-------- Original Message -------- From:Jens Madsen notifications@github.com Sent:Tue, 20 Dec 2016 08:50:59 +0000 To:boutproject/BOUT-dev BOUT-dev@noreply.github.com Cc:Subscribed subscribed@noreply.github.com Subject:[boutproject/BOUT-dev] laplacexz should exit when g13 \neq 0 (#425)

lalplacexz assumes that gxz = g13 = 0. Therefore, if g13 \neq 0 the code should exit. Perhaps we could allow the user to set a flag which specifically allowed using laplacexz with gxz \neq 0 ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/boutproject/BOUT-dev","title":"boutproject/BOUT-dev","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/boutproject/BOUT-dev"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"laplacexz should exit when g13 \neq 0 (#425)"}],"action":{"name":"View Issue","url":"https://github.com/boutproject/BOUT-dev/issues/425"}}}

[bendudson]

Now fixed by #513