search

boutproject / BOUT-dev

BOUT++: Plasma fluid finite-difference simulation code in curvilinear coordinate systems
http://boutproject.github.io/
GNU Lesser General Public License v3.0
182 stars 95 forks source link

genZMode no longer used? #645

Closed ZedThree closed 6 years ago

ZedThree commented 7 years ago

genZMode doesn't appear to be used any more. It's not called in the main library and none of the examples use it, at least. It also takes an unused parameter, n, so it's possible it doesn't even do the "right" thing either.

Should we deprecate/remove it?

bendudson commented 7 years ago

I think it should be removed. From the documentation it looks like "n" should be inside the sin() function, but is not used so doesn't do the right thing. This can easily be replaced by clearer methods e.g. FieldFactory

ZedThree commented 7 years ago

Will deprecate in 4.1, to be removed/replaced in a future version

ZedThree commented 6 years ago

Fixed in #735