search

boutproject / boutdata

GNU Lesser General Public License v3.0
0 stars 2 forks source link

Multiline values #74

Closed bendudson closed 2 years ago

bendudson commented 2 years ago

In BOUT++ next (not master) if input values contain unbalanced brackets or parentheses ('[]' or '()') then reading continues to the next line. This allows long expressions (or lists in Hermes-3) to be spread over multiple lines.

The corresponding code in BOUT++ is here: https://github.com/boutproject/BOUT-dev/blob/next/src/sys/options/options_ini.cxx#L132 Looking at this again, that line should probably be while (count == 0)

Fixes #73.

johnomotani commented 2 years ago

I suspect the lint CI is failing because version 5.0.x of flake8 has broken reading its configuration (I think they were on 5.0.0 a month or so ago, and seem to be up to 5.0.4 already so I guess they're working hard!). I had a similar problem on another repo. I think it's OK to just ignore that failure for now, and give flake8 a bit longer to iron its bugs out. We could also pin flake8 to 4.x, but we'd just have to keep checking if they've fixed things and change it later - something to think about if it keeps being a problem for a long time IMO.