Closed johnomotani closed 4 years ago
Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Merging #104 into master will increase coverage by
0.87%
. The diff coverage is92.00%
.
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 48.05% 48.92% +0.87%
==========================================
Files 11 11
Lines 1105 1120 +15
Branches 227 227
==========================================
+ Hits 531 548 +17
+ Misses 506 505 -1
+ Partials 68 67 -1
Impacted Files | Coverage Δ | |
---|---|---|
xbout/boutdataset.py | 66.45% <86.66%> (+1.52%) |
:arrow_up: |
xbout/boutdataarray.py | 66.10% <100.00%> (+3.13%) |
:arrow_up: |
xbout/geometries.py | 75.26% <100.00%> (+0.82%) |
:arrow_up: |
xbout/load.py | 75.96% <0.00%> (+0.77%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 41921a6...1ce69d4. Read the comment docs.
I've been working on some methods to interpolate in the parallel direction to increase the poloidal resolution of variables, porting @friva000's on shifting to/from field-aligned coordinates and parallel interpolation to xBOUT. I'm splitting up the changes into a few PRs to make them easier to review. This first one is a few small independent bits and pieces that provide some functionality that will be needed later.