search

boutproject / xBOUT

Collects BOUT++ data from parallelized simulations into xarray.
https://xbout.readthedocs.io/en/latest/
Apache License 2.0
22 stars 10 forks source link

from_region() method for BoutDataset #130

Closed johnomotani closed 4 years ago

johnomotani commented 4 years ago

Adds a from_region() method for BoutDataset with the shared implementation between BoutDataArray and BoutDataset moved into a utility function in region.py.

WIP - to be merged after #129.

pep8speaks commented 4 years ago

Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-09-07 14:28:54 UTC
codecov-commenter commented 4 years ago

Codecov Report

Merging #130 into master will increase coverage by 0.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   77.36%   77.43%   +0.07%     
==========================================
  Files          14       14              
  Lines        1820     1826       +6     
  Branches      393      393              
==========================================
+ Hits         1408     1414       +6     
  Misses        277      277              
  Partials      135      135
Impacted Files Coverage Δ
xbout/boutdataarray.py 84.79% <100.00%> (-1.58%) :arrow_down:
xbout/boutdataset.py 75.18% <100.00%> (+0.28%) :arrow_up:
xbout/region.py 86.85% <100.00%> (+0.92%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f00227...7eb4a96. Read the comment docs.