search

boutproject / xBOUT

Collects BOUT++ data from parallelized simulations into xarray.
https://xbout.readthedocs.io/en/latest/
Apache License 2.0
22 stars 10 forks source link

List of Datasets argument to open_boutdataset() #132

Closed johnomotani closed 4 years ago

johnomotani commented 4 years ago

Allow open_boutdataset() to optionally take a list of existing Datasets instead of a filename-glob. Useful for unit tests which no longer have to create files on disk and then read them. Speeds up the unit tests, which is useful so we can add more tests in other PRs without making Travis time out. A few unit tests do still read and write files, so this functionality is still tested.

pep8speaks commented 4 years ago

Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-09-04 00:35:52 UTC
codecov-commenter commented 4 years ago

Codecov Report

Merging #132 into master will increase coverage by 0.13%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   71.61%   71.74%   +0.13%     
==========================================
  Files          14       14              
  Lines        1705     1727      +22     
  Branches      363      371       +8     
==========================================
+ Hits         1221     1239      +18     
- Misses        380      383       +3     
- Partials      104      105       +1
Impacted Files Coverage Δ
xbout/load.py 81.23% <83.33%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d6d390...0eb142c. Read the comment docs.