johnomotani commented 4 years ago

Doesn't save us any code in xBOUT, but is testable, used once (in place of a few lines of code that couldn't be tested individually) and can be useful downstream, e.g. in xSTORM.

pep8speaks commented 4 years ago

Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-09-21 17:13:04 UTC

codecov-commenter commented 4 years ago

Codecov Report

Merging #143 into master will increase coverage by 0.14%. The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   77.87%   78.02%   +0.14%     
==========================================
  Files          14       14              
  Lines        2183     2207      +24     
  Branches      496      504       +8     
==========================================
+ Hits         1700     1722      +22     
- Misses        308      309       +1     
- Partials      175      176       +1

Impacted Files	Coverage Δ
xbout/utils.py	`81.73% <92.00%> (+0.89%)`	:arrow_up:
xbout/geometries.py	`79.02% <100.00%> (-0.15%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b42b3e3...f9fd409. Read the comment docs.

boutproject / xBOUT

Utility function for creating 1d coordinates #143

Comment last updated at 2020-09-21 17:13:04 UTC

Codecov Report