It would be nice to have a poloidal_plot argument to plot2d_wrapper() (and so for BoutDataArray.pcolormesh(), BoutDataArray.contour() and BoutDataArray.contourf()) like animate2D() and animate_list() have so that we can turn off the poloidal plot feature and just plot any simple slice of the data. We've got a few extra features (e.g. simple log-scaling of the colorbar) compared to the base xarray methods that would be nice to have. Needs a bit of restructuring of plot2d_wrapper() to not always use regions.
Question is what the sensible default value for poloidal_plot would be. I think my ideal solution would be: True if spatial dimensions are the ones corresponding to bout_xdim and bout_ydim and the DataArray has regions (i.e. if a poloidal_plot is possible); and False otherwise. That is different from animate2D() and animate_list() (which default to poloidal_plot=False) - I'd favour updating them to have this default behaviour. It would keep the current behaviour of plot2d_wrapper() for cases that it can currently plot.
It would be nice to have a
poloidal_plotargument toplot2d_wrapper()(and so forBoutDataArray.pcolormesh(),BoutDataArray.contour()andBoutDataArray.contourf()) likeanimate2D()andanimate_list()have so that we can turn off the poloidal plot feature and just plot any simple slice of the data. We've got a few extra features (e.g. simple log-scaling of the colorbar) compared to the base xarray methods that would be nice to have. Needs a bit of restructuring ofplot2d_wrapper()to not always useregions.Question is what the sensible default value for
poloidal_plotwould be. I think my ideal solution would be:Trueif spatial dimensions are the ones corresponding tobout_xdimandbout_ydimand the DataArray hasregions(i.e. if apoloidal_plotis possible); andFalseotherwise. That is different fromanimate2D()andanimate_list()(which default topoloidal_plot=False) - I'd favour updating them to have this default behaviour. It would keep the current behaviour ofplot2d_wrapper()for cases that it can currently plot.