search

boutproject / xBOUT

Collects BOUT++ data from parallelized simulations into xarray.
https://xbout.readthedocs.io/en/latest/
Apache License 2.0
22 stars 10 forks source link

Fix multiple-coordinate-values error for core-only/limiter cases #173

Closed johnomotani closed 4 years ago

johnomotani commented 4 years ago

When values of the theta coordinate for the guard cells were taken from the other side of the branch cut for core-only or limiter cases, they did not join continuously onto the main grid's theta values. Work around this by adding an offset calculated from a linear extrapolation from the grid values (which is exact for constant grid spacing, which is usually the case for the y-direction).

pep8speaks commented 4 years ago

Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1291:17: W503 line break before binary operator Line 1292:17: W503 line break before binary operator Line 1311:17: W503 line break before binary operator Line 1312:17: W503 line break before binary operator Line 1391:17: W503 line break before binary operator Line 1392:17: W503 line break before binary operator Line 1411:17: W503 line break before binary operator Line 1412:17: W503 line break before binary operator

Line 706:89: E501 line too long (89 > 88 characters)

Comment last updated at 2020-12-01 01:18:03 UTC
codecov-io commented 4 years ago

Codecov Report

Merging #173 (b433bb5) into master (0bae8f6) will decrease coverage by 0.60%. The diff coverage is 39.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage   75.61%   75.01%   -0.61%     
==========================================
  Files          12       12              
  Lines        2042     2065      +23     
  Branches      467      475       +8     
==========================================
+ Hits         1544     1549       +5     
- Misses        333      347      +14     
- Partials      165      169       +4
Impacted Files Coverage Δ
xbout/region.py 85.09% <39.13%> (-2.41%) :arrow_down:
xbout/plotting/utils.py 74.25% <0.00%> (-2.98%) :arrow_down:
xbout/boutdataset.py 75.07% <0.00%> (-0.31%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0bae8f6...b433bb5. Read the comment docs.