search

boutproject / xBOUT

Collects BOUT++ data from parallelized simulations into xarray.
https://xbout.readthedocs.io/en/latest/
Apache License 2.0
22 stars 10 forks source link

Option for cumulative time integral in integrate_midpoints() [bump minimum xarray to 0.18.0] #201

Closed johnomotani closed 3 years ago

johnomotani commented 3 years ago

Adds an option to make the time integral in integrate_midpoints cumulative (t-dependent) instead of total.

Requires the minimum xarray to be 0.18.0 to provide the cumulative_integrate() method. Does anyone have a problem with this?

codecov-commenter commented 3 years ago

Codecov Report

Merging #201 (e7ba18f) into master (3ce53cc) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   75.11%   75.13%   +0.01%     
==========================================
  Files          14       14              
  Lines        2616     2618       +2     
  Branches      615      616       +1     
==========================================
+ Hits         1965     1967       +2     
  Misses        420      420              
  Partials      231      231
Impacted Files Coverage Δ
xbout/boutdataset.py 76.10% <100.00%> (+0.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ce53cc...e7ba18f. Read the comment docs.

johnomotani commented 3 years ago

Argh, I've messed up the merge of master. Going to rebase this branch on the current master to clean things up - just a warning in case anyone is currently using the branch. I'm planning to merge this PR into master very soon anyway, so hopefully it does not bother anyone!