Closed johnomotani closed 3 years ago
PS I suspect this helps test runs using pytest --long
more than regular runs (without the --long
) - there probably aren't as many duplicated inputs to avoid recreating in the regular runs...
Merging #215 (535406f) into master (2478fe6) will decrease coverage by
0.01%
. The diff coverage is50.00%
.
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
- Coverage 75.37% 75.35% -0.02%
==========================================
Files 14 14
Lines 2644 2646 +2
Branches 622 623 +1
==========================================
+ Hits 1993 1994 +1
Misses 421 421
- Partials 230 231 +1
Impacted Files | Coverage Δ | |
---|---|---|
xbout/load.py | 77.99% <50.00%> (-0.16%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2478fe6...535406f. Read the comment docs.
This looks like it shaves a good chunk of time off of the Github Actions at least!
Shout out to gelidum, a nice package which converts many kinds of object to hashable things that can be used as dict
keys :+1: Now available on conda-forge!
PS I'm going to release a new minor version before I forget to update xbout
's dependencies on conda-forge.
When creating input files/Datasets for tests, save them in a cache and return a copy if the same arguments are given to the data-creation function(s). Helps to speed things up a bit - seems to shave about 20mins of the CI runs.
Includes an update changing the use of Pytest's
tmpdir_factory
andtmpdir
fortmp_path_factory
andtmp_path
. The latter return apathlib.Path
object instead of Pytests'spy.path
, which is more convenient and compatible with standard Python path-handling. I think those changes are actually most of the changed lines though - for just the caching updates, see 4e4e1427c1c4ac2aeae1e9cbd99e71ccbefd243c and ac191a3a2e45c7370dd8d7c71dfbfe0e9bddcb87.Partial fix for #213.