Implement basic FCI geometry

[dschwoerer]

9545faf does the job for me, to get the coordinates included. (The rest is just updates from master)

[pep8speaks]

Hello @dschwoerer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file xbout/boutdataarray.py:

Line 613:13: W503 line break before binary operator

• In the file xbout/boutdataset.py:

Line 415:89: E501 line too long (91 > 88 characters) Line 423:25: W503 line break before binary operator Line 425:21: W503 line break before binary operator Line 427:25: W503 line break before binary operator Line 429:21: W503 line break before binary operator

• In the file xbout/load.py:

Line 558:13: W503 line break before binary operator

• In the file xbout/plotting/animate.py:

Line 20:5: W503 line break before binary operator

• In the file xbout/plotting/plotfuncs.py:

Line 19:5: W503 line break before binary operator

• In the file xbout/region.py:

Line 1538:17: W503 line break before binary operator Line 1539:17: W503 line break before binary operator Line 1558:17: W503 line break before binary operator Line 1559:17: W503 line break before binary operator Line 1638:17: W503 line break before binary operator Line 1639:17: W503 line break before binary operator Line 1658:17: W503 line break before binary operator Line 1659:17: W503 line break before binary operator

• In the file xbout/tests/test_boutdataset.py:

Line 1147:89: E501 line too long (89 > 88 characters) Line 1388:13: W503 line break before binary operator Line 1405:13: W503 line break before binary operator Line 1431:13: W503 line break before binary operator Line 1432:13: W503 line break before binary operator Line 1433:13: W503 line break before binary operator Line 1448:13: W503 line break before binary operator Line 1465:13: W503 line break before binary operator Line 1466:13: W503 line break before binary operator Line 1489:13: W503 line break before binary operator Line 1490:13: W503 line break before binary operator Line 1499:13: W503 line break before binary operator Line 1500:13: W503 line break before binary operator Line 1508:13: W503 line break before binary operator Line 1509:13: W503 line break before binary operator Line 1517:13: W503 line break before binary operator Line 1518:13: W503 line break before binary operator Line 1576:17: W503 line break before binary operator Line 1577:17: W503 line break before binary operator Line 1578:17: W503 line break before binary operator Line 1587:13: W503 line break before binary operator Line 1588:13: W503 line break before binary operator Line 1596:13: W503 line break before binary operator Line 1597:13: W503 line break before binary operator Line 1607:13: W503 line break before binary operator Line 1608:13: W503 line break before binary operator Line 1621:13: W503 line break before binary operator Line 1636:13: W503 line break before binary operator

• In the file xbout/utils.py:

Line 67:9: W503 line break before binary operator Line 719:17: W503 line break before binary operator Line 720:17: W503 line break before binary operator Line 729:17: W503 line break before binary operator Line 730:17: W503 line break before binary operator

Comment last updated at 2021-10-11 13:35:08 UTC

[codecov-commenter]

Codecov Report

Merging #224 (41372bd) into fci-geometry (6aa3494) will decrease coverage by 1.17%. The diff coverage is 67.12%.

@@               Coverage Diff                @@
##           fci-geometry     #224      +/-   ##
================================================
- Coverage         76.51%   75.34%   -1.18%     
================================================
  Files                12       15       +3     
  Lines              1950     2701     +751     
  Branches            437      631     +194     
================================================
+ Hits               1492     2035     +543     
- Misses              306      434     +128     
- Partials            152      232      +80     

Impacted Files	Coverage Δ
xbout/plotting/plotfuncs.py	48.27% <33.33%> (-0.85%)	:arrow_down:
xbout/plotting/animate.py	46.08% <52.25%> (+6.89%)	:arrow_up:
xbout/boutdataarray.py	78.12% <56.38%> (-8.01%)	:arrow_down:
xbout/geometries.py	70.17% <59.70%> (-8.85%)	:arrow_down:
xbout/plotting/utils.py	75.24% <66.66%> (+4.41%)	:arrow_up:
xbout/load.py	77.99% <69.69%> (-1.35%)	:arrow_down:
xbout/boutdataset.py	75.60% <74.54%> (-1.03%)	:arrow_down:
xbout/region.py	83.89% <75.00%> (-1.60%)	:arrow_down:
xbout/fastoutput.py	88.88% <88.88%> (ø)
xbout/utils.py	83.03% <94.44%> (ø)
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6aa3494...41372bd. Read the comment docs.

[dschwoerer]

@johnomotani any idea why codecov is failing?