boutproject / xBOUT

Collects BOUT++ data from parallelized simulations into xarray.
https://xbout.readthedocs.io/en/latest/
Apache License 2.0
21 stars 10 forks source link

Fix color scales in `animate_list()` #225

Closed johnomotani closed 3 years ago

johnomotani commented 3 years ago

Need to always pass norm to amp.blocks.Pcolormesh(), as well as cmap, otherwise different regions actually get normalised to their own min/max.

Bug probably introduced in #196.

codecov-commenter commented 3 years ago

Codecov Report

Merging #225 (fe74874) into master (43e3735) will decrease coverage by 0.03%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   75.68%   75.65%   -0.04%     
==========================================
  Files          15       15              
  Lines        2682     2682              
  Branches      631      631              
==========================================
- Hits         2030     2029       -1     
  Misses        420      420              
- Partials      232      233       +1     
Impacted Files Coverage Δ
xbout/plotting/animate.py 46.08% <0.00%> (ø)
xbout/utils.py 82.73% <0.00%> (-0.30%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 43e3735...fe74874. Read the comment docs.