Closed johnomotani closed 2 years ago
Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Merging #232 (27a75f7) into master (f2dd91e) will decrease coverage by
0.53%
. The diff coverage is52.00%
.
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 75.91% 75.38% -0.54%
==========================================
Files 15 15
Lines 2745 2779 +34
Branches 655 668 +13
==========================================
+ Hits 2084 2095 +11
- Misses 425 442 +17
- Partials 236 242 +6
Impacted Files | Coverage Δ | |
---|---|---|
xbout/boutdataset.py | 76.21% <ø> (ø) |
|
xbout/region.py | 83.55% <0.00%> (-2.33%) |
:arrow_down: |
xbout/geometries.py | 69.63% <25.00%> (-1.41%) |
:arrow_down: |
xbout/utils.py | 83.38% <75.00%> (-0.77%) |
:arrow_down: |
xbout/load.py | 78.01% <100.00%> (+0.23%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f2dd91e...27a75f7. Read the comment docs.
Pulled out from #231 because they may be independently useful, so useful to merge before #231 is finished.