boutproject / xBOUT

Collects BOUT++ data from parallelized simulations into xarray.
https://xbout.readthedocs.io/en/latest/
Apache License 2.0
22 stars 10 forks source link

Workaround for old squashed files with inconsistent y-boundary cells #240

Closed johnomotani closed 2 years ago

johnomotani commented 2 years ago

Older 'squashed' output files for double-null grids often included y-boundary cells for the lower target (ends of the logical grid) but not the upper target (somewhere in the middle of the logical grid). Add some special handling to allow these files to be opened, as long as keep_yboundaries = False.

codecov-commenter commented 2 years ago

Codecov Report

Merging #240 (29e7053) into master (fb89188) will decrease coverage by 0.24%. The diff coverage is 10.00%.

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   74.95%   74.71%   -0.25%     
==========================================
  Files          15       15              
  Lines        2787     2796       +9     
  Branches      672      675       +3     
==========================================
  Hits         2089     2089              
- Misses        454      462       +8     
- Partials      244      245       +1     
Impacted Files Coverage Δ
xbout/load.py 75.31% <10.00%> (-1.77%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more