boutproject / xBOUT

Collects BOUT++ data from parallelized simulations into xarray.
https://xbout.readthedocs.io/en/latest/
Apache License 2.0
21 stars 8 forks source link

Remove unnecessary (and possibly wrong) .data when y_fine is used #254

Closed johnomotani closed 1 year ago

johnomotani commented 1 year ago

The use of y_fine.data rather than y_fine is probably left over from an early implementation where y_fine was a DataArray rather than a numpy array.

codecov-commenter commented 1 year ago

Codecov Report

Merging #254 (4024944) into master (8cd6781) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   73.81%   73.81%           
=======================================
  Files          13       13           
  Lines        2517     2517           
  Branches      600      608    +8     
=======================================
  Hits         1858     1858           
+ Misses        437      435    -2     
- Partials      222      224    +2     
Impacted Files Coverage Δ
xbout/boutdataarray.py 78.67% <ø> (ø)
xbout/plotting/animate.py 46.08% <0.00%> (ø)
xbout/plotting/plotfuncs.py 48.27% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more