Closed johnomotani closed 1 year ago
Merging #261 (90e532d) into master (4627709) will decrease coverage by
0.68%
. The diff coverage is18.18%
.
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
- Coverage 73.62% 72.93% -0.69%
==========================================
Files 13 13
Lines 2529 2557 +28
Branches 607 619 +12
==========================================
+ Hits 1862 1865 +3
- Misses 442 463 +21
- Partials 225 229 +4
Impacted Files | Coverage Δ | |
---|---|---|
xbout/load.py | 69.42% <18.18%> (-4.04%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Add several workarounds to allow data from simulations run using BOUT++ v3.x to be loaded, and allow (some)
xbout
methods to work.Workarounds:
jyseps1_1
, etc., from the grid filedirection_y
attribute toField3D
variables, which is always"Aligned"
for BOUT-3 data.cell_location = "CELL_CENTRE"
attribute to all fields. Thecell_location
was not recorded by BOUT++ in v3. Also, staggered grid support in BOUT++ was only partial so treating all variables as if they wereCELL_CENTRE
may be consistent with BOUT-3 (e.g. when shifting between aligned and non-aligned grids, always usingzShift
fromCELL_CENTRE
is consistent with BOUT-3).nz = MZ-1
in the metadata.data_vars = "different"
to work aroundhist_hi
andtt
(which are expected byxbout
) not being present - effect is to concatenate any variables that are different in different files (this may be slightly slower)._read_splitting()
, calculatenx
andny
fromMXSUB
,NXPE
,MXG
,MYSUB
, andNYPE
, as they were not written to output files by BOUT-3.jyseps2_1
orjyseps1_2
, but anywaybout-squashoutput
did not save those cells at the time, so skipping the handling should not cause a problem. If the upper target cells were somehow present, an error (although with an unhelpful message) would be raised (I think...).