search

boutproject / xBOUT

Collects BOUT++ data from parallelized simulations into xarray.
https://xbout.readthedocs.io/en/latest/
Apache License 2.0
22 stars 10 forks source link

Test geometries #58

Closed johnomotani closed 5 years ago

johnomotani commented 5 years ago

Builds on #55, so merging into fix-test-against-collect.

Adds unit tests for loading datasets with 'toroidal' or 's-alpha' geometries. These show the need to be able to pass a grid file to get psixy, Rxy, Zxy, hthe variables, which are not needed by BOUT++ so are never loaded or saved to the dump files. Therefore reinstates the option to pass a gridfilepath, but now the grid file can be opened with just open_boutdataset :tada:

Also includes a work-around to tell Travis to exclude xarray-0.14.0, which fixes the Travis tests.

Resolves #17.

pep8speaks commented 5 years ago

Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-10-28 20:40:07 UTC
codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (fix-test-against-collect@212f913). Click here to learn what that means. The diff coverage is 55.55%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##             fix-test-against-collect      #58   +/-   ##
===========================================================
  Coverage                            ?   69.14%           
===========================================================
  Files                               ?        8           
  Lines                               ?      444           
  Branches                            ?       93           
===========================================================
  Hits                                ?      307           
  Misses                              ?       85           
  Partials                            ?       52
Impacted Files Coverage Δ
xbout/boutdataset.py 46.87% <ø> (ø)
xbout/load.py 77.65% <100%> (ø)
xbout/geometries.py 75.64% <46.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 212f913...3fc4f02. Read the comment docs.