search

boutproject / xBOUT

Collects BOUT++ data from parallelized simulations into xarray.
https://xbout.readthedocs.io/en/latest/
Apache License 2.0
22 stars 10 forks source link

Fix plotting to allow for core-only grids #67

Closed rdoyle45 closed 5 years ago

rdoyle45 commented 5 years ago

Adds function that checks whether ixseps1 and ixseps2 are >= nx, suggesting a core only grid with no separatrix or target info to be plotted.

pep8speaks commented 5 years ago

Hello @rdoyle45! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-12-04 14:47:52 UTC
rdoyle45 commented 5 years ago

Fixes the issue with core only grids. @johnomotani

codecov-io commented 5 years ago

Codecov Report

Merging #67 into master will decrease coverage by 0.22%. The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   44.23%   44.01%   -0.23%     
==========================================
  Files           8        8              
  Lines         737      743       +6     
  Branches      141      142       +1     
==========================================
+ Hits          326      327       +1     
- Misses        357      362       +5     
  Partials       54       54
Impacted Files Coverage Δ
xbout/plotting/plotfuncs.py 9.33% <25%> (-0.39%) :arrow_down:
xbout/plotting/utils.py 4.91% <33.33%> (+0.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4c61bb...b2f42de. Read the comment docs.