boutproject / xBOUT

Collects BOUT++ data from parallelized simulations into xarray.
https://xbout.readthedocs.io/en/latest/
Apache License 2.0
22 stars 10 forks source link

Update layout of plots in animate_list #95

Closed johnomotani closed 4 years ago

johnomotani commented 4 years ago

Make aspect ratio setting user-settable.

Make tight_layout() optional, and default to False, because tight_layout() sometimes makes plots overlap.

Check for str explicitly in _expand_list_arg, because we do not want to treat a str argument like a list.

codecov-io commented 4 years ago

Codecov Report

Merging #95 into master will increase coverage by 0.1%. The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #95     +/-   ##
=========================================
+ Coverage   47.85%   47.96%   +0.1%     
=========================================
  Files          11       11             
  Lines        1072     1080      +8     
  Branches      216      220      +4     
=========================================
+ Hits          513      518      +5     
  Misses        497      497             
- Partials       62       65      +3
Impacted Files Coverage Δ
xbout/plotting/animate.py 42.02% <0%> (ø) :arrow_up:
xbout/boutdataset.py 67.12% <75%> (-0.27%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82d3e05...6911047. Read the comment docs.

rdoyle45 commented 4 years ago

If you have no more changes to make John, I think this is good to merge.