search

bowbahdoe / caveman

Clojure Web Framework
https://caveman.mccue.dev
12 stars 8 forks source link

Fix missing dash in docker compose and missing system-so-far in call to start-db #6

Closed maacl closed 1 month ago

netlify[bot] commented 1 month ago

Deploy Preview for resplendent-mermaid-f821af ready!

Name Link
Latest commit 27f12a82933ee3ac4b783b52c1e715c3d3e78670
Latest deploy log https://app.netlify.com/sites/resplendent-mermaid-f821af/deploys/671e644ab1f4ac000826d678
Deploy Preview https://deploy-preview-6--resplendent-mermaid-f821af.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Mertzenich commented 1 month ago

You do not need the dash for docker compose: docker compose up -d and docker-compose up -d do the same thing. I've always used docker SPACE compose and didn't even know docker-compose was a thing (the official documentation appears to use a space).

maacl commented 1 month ago

docker compose fails on my machine, Ubuntu 22 under WSL.

On Mon, 28 Oct 2024, 00:25 Adam Mertzenich, @.***> wrote:

You do not need the dash for docker compose: docker compose up -d and docker-compose up -d do the same thing.

— Reply to this email directly, view it on GitHub https://github.com/bowbahdoe/caveman/pull/6#issuecomment-2440216608, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPUXCG4IGOICXOZMZA673Z5VY7TAVCNFSM6AAAAABQV6G7K2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGIYTMNRQHA . You are receiving this because you authored the thread.Message ID: @.***>

bowbahdoe commented 1 month ago

You just need a newer version of docker https://www.docker.com/blog/new-docker-compose-v2-and-v1-deprecation/

bowbahdoe commented 1 month ago

For the other change, start-db doesn't need the system until the next step.

maacl commented 1 month ago

Ah, makes sense.

On Mon, 28 Oct 2024 at 07:53, Ethan McCue @.***> wrote:

You just need a newer version of docker https://www.docker.com/blog/new-docker-compose-v2-and-v1-deprecation/

— Reply to this email directly, view it on GitHub https://github.com/bowbahdoe/caveman/pull/6#issuecomment-2440695028, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPUXAU7B4QAOGVOYT2FVDZ5XNOTAVCNFSM6AAAAABQV6G7K2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGY4TKMBSHA . You are receiving this because you authored the thread.Message ID: @.***>

maacl commented 1 month ago

And then again maybe not. The version of docker you get with Ubuntu 22 LTS does not support docker compose. I think that will be a common issue.

On Mon, 28 Oct 2024 at 07:56, Martin Clausen @.***> wrote:

Ah, makes sense.

On Mon, 28 Oct 2024 at 07:53, Ethan McCue @.***> wrote:

You just need a newer version of docker https://www.docker.com/blog/new-docker-compose-v2-and-v1-deprecation/

— Reply to this email directly, view it on GitHub https://github.com/bowbahdoe/caveman/pull/6#issuecomment-2440695028, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPUXAU7B4QAOGVOYT2FVDZ5XNOTAVCNFSM6AAAAABQV6G7K2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGY4TKMBSHA . You are receiving this because you authored the thread.Message ID: @.***>

maacl commented 1 month ago

Yeah, I missed that. Sorry.

On Mon, 28 Oct 2024 at 07:54, Ethan McCue @.***> wrote:

For the other change, start-db doesn't need the system until the next step.

— Reply to this email directly, view it on GitHub https://github.com/bowbahdoe/caveman/pull/6#issuecomment-2440696829, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPUXFT35OQP32HQQCW6LTZ5XNTRAVCNFSM6AAAAABQV6G7K2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGY4TMOBSHE . You are receiving this because you authored the thread.Message ID: @.***>