search

bowbahdoe / edn-format

Rust implementation of the EDN data format
MIT License
21 stars 3 forks source link

Fix issues with parsing and emitting EDN characters #6

Closed skyrod-vactai closed 1 year ago

skyrod-vactai commented 1 year ago

Fixes #4, #5. All the tests pass (including a few extra asserts I added), so hopefully it's not breaking anything.

bowbahdoe commented 1 year ago

@skyrod-vactai Hi - can you clarify what issues this is solving?

bowbahdoe commented 1 year ago

nevermind - i see the linked issues. Can you fix the failing lints?

skyrod-vactai commented 1 year ago

Thanks for looking at this @bowbahdoe ! I fixed the 2 lint errors that I caused. The other ones appear to be in the existing code.

The coverage error, I am not sure what that's about, it doesn't appear to be caused by my PR either:

  Installing /home/runner/.cargo/bin/cargo-tarpaulin
   Installed package `cargo-tarpaulin v0.27.0` (executable `cargo-tarpaulin`)
error: invalid value 'Xml' for '--out [<FMT>...]'
  [possible values: json, stdout, xml, html, lcov]

  tip: a similar value exists: 'xml'
bowbahdoe commented 1 year ago

@skyrod-vactai I published a new version. 3.3.0 which includes this change

skyrod-vactai commented 1 year ago

Thanks! Will upgrade and try it out.