search

boweiliu / Marathon

Marathon is a factorio mod designed to increase the length and difficulty.
ISC License
3 stars 1 forks source link

Casting price changes with Angel's smelting 0.3.12 #9

Open pjf opened 7 years ago

pjf commented 7 years ago

Angel's smelting 0.3.12 was recently released, and this seems to result in some unexpected casting changes.

It's possible to see these with a number of uncommon elements (gold, silicon, aluminium), but to take aluminium in particular (using Marathomation 0.2.41):

While Angel's 0.3.12 release makes a few small balancing tweaks, this is a 4.5x difference in yield.

The changelog suggests that some plates have shifted tabs, and sure enough a lot of materials have their subgroups changed in Angel's smelting-override-global.lua:

data.raw["item"]["aluminium-plate"].subgroup = "angels-aluminium-casting"

However In bobsmods/recipe-smelting.lua we use the subgroups bob-material and bob-alloy to determine which recipes to explode. While I haven't confirmed it, I suspect Angel's 0.3.12 subgroup changes are moving things out of these categories, and as a result we no longer explode them.

Apologies this is a bug report and not a pull-request, but I'm hoping my investigation will help make patching easier.

pjf commented 7 years ago

Here's the relevant chunk of the diff between Angel's smelting 0.3.11 and 0.3.12 showing the changes:

diff

``` if bobmods and bobmods.plates then data.raw["item"]["tin-plate"].icon = "__angelssmelting__/graphics/icons/plate-tin.png" + data.raw["item"]["tin-plate"].subgroup = "angels-tin-casting" + data.raw["item"]["tin-plate"].order = "a" data.raw["item"]["silver-plate"].icon = "__angelssmelting__/graphics/icons/plate-silver.png" + data.raw["item"]["silver-plate"].subgroup = "angels-silver-casting" + data.raw["item"]["silver-plate"].order = "a" data.raw["item"]["lead-plate"].icon = "__angelssmelting__/graphics/icons/plate-lead.png" + data.raw["item"]["lead-plate"].subgroup = "angels-lead-casting" + data.raw["item"]["lead-plate"].order = "a" data.raw["item"]["glass"].icon = "__angelssmelting__/graphics/icons/plate-glass.png" + data.raw["item"]["glass"].subgroup = "angels-glass-casting" + data.raw["item"]["glass"].order = "a" data.raw["item"]["gold-plate"].icon = "__angelssmelting__/graphics/icons/plate-gold.png" + data.raw["item"]["gold-plate"].subgroup = "angels-gold-casting" + data.raw["item"]["gold-plate"].order = "a" data.raw["item"]["nickel-plate"].icon = "__angelssmelting__/graphics/icons/plate-nickel.png" + data.raw["item"]["nickel-plate"].subgroup = "angels-nickel-casting" + data.raw["item"]["nickel-plate"].order = "a" data.raw["item"]["zinc-plate"].icon = "__angelssmelting__/graphics/icons/plate-zinc.png" + data.raw["item"]["zinc-plate"].subgroup = "angels-zinc-casting" + data.raw["item"]["zinc-plate"].order = "a" data.raw["item"]["aluminium-plate"].icon = "__angelssmelting__/graphics/icons/plate-aluminium.png" + data.raw["item"]["aluminium-plate"].subgroup = "angels-aluminium-casting" + data.raw["item"]["aluminium-plate"].order = "a" data.raw["item"]["lead-oxide"].icon = "__angelssmelting__/graphics/icons/solid-lead-oxide.png" + data.raw["item"]["lead-oxide"].subgroup = "angels-lead" + data.raw["item"]["lead-oxide"].order = "d" data.raw["item"]["alumina"].icon = "__angelssmelting__/graphics/icons/solid-aluminium-oxide.png" + data.raw["item"]["alumina"].subgroup = "angels-aluminium" + data.raw["item"]["alumina"].order = "f" data.raw["item"]["tungsten-oxide"].icon = "__angelssmelting__/graphics/icons/solid-tungsten-oxide.png" + data.raw["item"]["tungsten-oxide"].subgroup = "angels-tungsten" + data.raw["item"]["tungsten-oxide"].order = "e" data.raw["item"]["powdered-tungsten"].icon = "__angelssmelting__/graphics/icons/powder-tungsten.png" + data.raw["item"]["powdered-tungsten"].subgroup = "angels-tungsten" + data.raw["item"]["powdered-tungsten"].order = "f" data.raw["item"]["cobalt-oxide"].icon = "__angelssmelting__/graphics/icons/solid-cobalt-oxide.png" + data.raw["item"]["cobalt-oxide"].subgroup = "angels-cobalt" + data.raw["item"]["cobalt-oxide"].order = "e" data.raw["item"]["silver-nitrate"].icon = "__angelssmelting__/graphics/icons/solid-silver-nitrate.png" + data.raw["item"]["silver-nitrate"].subgroup = "angels-silver" + data.raw["item"]["silver-nitrate"].order = "d" data.raw["item"]["titanium-plate"].icon = "__angelssmelting__/graphics/icons/plate-titanium.png" + data.raw["item"]["titanium-plate"].subgroup = "angels-titanium-casting" + data.raw["item"]["titanium-plate"].order = "a" data.raw["item"]["tungsten-plate"].icon = "__angelssmelting__/graphics/icons/plate-tungsten.png" + data.raw["item"]["tungsten-plate"].subgroup = "angels-tungsten-casting" + data.raw["item"]["tungsten-plate"].order = "a" data.raw["item"]["silicon"].icon = "__angelssmelting__/graphics/icons/plate-silicon.png" + data.raw["item"]["silicon"].subgroup = "angels-silicon-casting" + data.raw["item"]["silicon"].order = "a" data.raw["item"]["cobalt-plate"].icon = "__angelssmelting__/graphics/icons/plate-cobalt.png" + data.raw["item"]["cobalt-plate"].subgroup = "angels-cobalt-casting" + data.raw["item"]["cobalt-plate"].order = "a" data.raw["item"]["brass-alloy"].icon = "__angelssmelting__/graphics/icons/plate-brass.png" + data.raw["item"]["brass-alloy"].subgroup = "angels-alloys-casting" + data.raw["item"]["brass-alloy"].order = "a" data.raw["item"]["bronze-alloy"].icon = "__angelssmelting__/graphics/icons/plate-bronze.png" + data.raw["item"]["bronze-alloy"].subgroup = "angels-alloys-casting" + data.raw["item"]["bronze-alloy"].order = "b" data.raw["item"]["electrum-alloy"].icon = "__angelssmelting__/graphics/icons/plate-electrum.png" + data.raw["item"]["electrum-alloy"].subgroup = "angels-alloys-casting" + data.raw["item"]["electrum-alloy"].order = "c" data.raw["item"]["gunmetal-alloy"].icon = "__angelssmelting__/graphics/icons/plate-gunmetal.png" + data.raw["item"]["gunmetal-alloy"].subgroup = "angels-alloys-casting" + data.raw["item"]["gunmetal-alloy"].order = "d" data.raw["item"]["invar-alloy"].icon = "__angelssmelting__/graphics/icons/plate-invar.png" + data.raw["item"]["invar-alloy"].subgroup = "angels-alloys-casting" + data.raw["item"]["invar-alloy"].order = "e" data.raw["item"]["nitinol-alloy"].icon = "__angelssmelting__/graphics/icons/plate-nitinol.png" + data.raw["item"]["nitinol-alloy"].subgroup = "angels-alloys-casting" + data.raw["item"]["nitinol-alloy"].order = "f" data.raw["item"]["cobalt-steel-alloy"].icon = "__angelssmelting__/graphics/icons/plate-cobalt-steel.png" + data.raw["item"]["cobalt-steel-alloy"].subgroup = "angels-alloys-casting" + data.raw["item"]["cobalt-steel-alloy"].order = "g" ```