issue/2610 Force https instead of git protocol for github

bower / bower

A package manager for the web

bower.io

MIT License

14.99k stars 1.85k forks source link

issue/2610 Force https instead of git protocol for github #2611

Closed oliverfoster closed 2 years ago

oliverfoster commented 2 years ago

fixes #2610

Fixed

Force https protocol when the git protocol is specific for github.com

oliverfoster commented 2 years ago

Appreciate your fix. Do the tests at https://github.com/bower/bower/blob/master/test/core/resolvers/gitHubResolver.js need updated?

No idea. If someone with the ability to merge and publish could tell me what I need to do, or take the suggestion and run with it, then I'll be happy.

Edufreitass commented 2 years ago

Guys, I opened another PR #2612 with @oliverfoster's fix and my test fixes, look there =)

oliverfoster commented 2 years ago

duplicate of https://github.com/bower/bower/pull/2612

fabioebt commented 2 years ago

Appreciate your fix. Do the tests at https://github.com/bower/bower/blob/master/test/core/resolvers/gitHubResolver.js need updated?

Please, take a look at this PR: https://github.com/bower/bower/pull/2612

rayanmarcus commented 2 years ago

It would be very helpful if this were resolved! 🙏