search

bower / decompress-zip

Module that decompresses zip files
MIT License
102 stars 76 forks source link

Avoid endless recursion on Windows. #11

Closed dangoor closed 10 years ago

dangoor commented 10 years ago

mkdir did not recognize the root directory on Windows.

dangoor commented 10 years ago

There appears to be a problem with the test data (Travis is failing, and it also wasn't working on my Mac)

wibblymat commented 10 years ago

Ha, good find. Thank you for the PR, but I think that recursing all the way back up to the root is kind of a dumb hack even if we fix it :)

I have a commit (that I thought I had already pushed) that changes it to check if the directory already exists. Knocks a few levels of recursion off. I'll push when I get home.

The test failures need looking at too. I saw this the other day and I'm not sure what the problem is. Retrying the Travis build seems to fix it, interesting that it doesn't work on Mac.

wibblymat commented 10 years ago

Fixed via 6b5675651541ed7bf63797866cf824ee6d312e13 instead.

I think I fixed the tests too.

Thanks again for the PR!

dangoor commented 10 years ago

@wibblymat I like that solution better. Wish I had thought of it myself (though I was mostly just focused on making the transition from unzip to decompress-zip in Brackets work :)

Thanks for the quick fix!