bower / decompress-zip

Module that decompresses zip files
MIT License
102 stars 76 forks source link

close file after decompression #21

Closed 0vaz closed 10 years ago

0vaz commented 10 years ago

Just want to ask about closing a zip file after decompression, what was the reason to not close the opened file? Right now the file cannot be deleted, moved or renamed after decompression until the process exit. Is it on purpose or a bug?

wibblymat commented 10 years ago

Going to go with bug... Will take a look. On 12 Mar 2014 09:30, "0vaz" notifications@github.com wrote:

Just want to ask about closing a zip file after decompression, what was the reason to not close the opened file? Right now the file cannot be deleted, moved or renamed after decompression until the process exit. Is it on purpose or a bug?

— Reply to this email directly or view it on GitHubhttps://github.com/bower/decompress-zip/issues/21 .

wibblymat commented 10 years ago

Fixed by 70feb2f60f0f9efa5b7d460e20986c638bd9ceaf. I have not done a release that includes this yet.

0vaz commented 10 years ago

Fine! Thanks.

danhaller commented 10 years ago

@wibblymat could you do that release please? It looks like this is breaking bower for windows users https://github.com/bower/bower/issues/1176

Thanks

wibblymat commented 10 years ago

Done, v0.0.6