search

bower / decompress-zip

Module that decompresses zip files
MIT License
102 stars 76 forks source link

decompress-zip doesn't preserve permissions #22

Closed jayproulx closed 8 years ago

jayproulx commented 10 years ago

E.g.

node -e "var DecompressZip = require('decompress-zip'), unzipper = new DecompressZip('blah.zip'); unzipper.extract({ path: './blah' });"

My executable files in ./blah are rw-r--r--, should be rwxr-xr-x

wibblymat commented 10 years ago

Done, v0.0.6

jayproulx commented 10 years ago

I just gave this a run through, it looks like the issue is still there.

https://github.com/jayproulx/decompress-zip-perms

Do you know what the issue might be? I can have a look and send a pull request.

wibblymat commented 10 years ago

Oh, I'm really sorry, I replied to the wrong thread

wibblymat commented 10 years ago

Setting permissions on the output files is not implemented yet, basically. It shouldn't be too hard to figure out because I do actually work out what the file permissions should be at https://github.com/bower/decompress-zip/blob/master/lib/structures.js#L92 but don't use that when creating the files (https://github.com/bower/decompress-zip/blob/master/lib/extractors.js#L81 is just one place we create files)