search

bower / decompress-zip

Module that decompresses zip files
MIT License
102 stars 76 forks source link

don't use graceful-fs #27

Closed andrewrk closed 10 years ago

andrewrk commented 10 years ago

What if I don't want to monkey patch fs? I have no choice if this module depends on graceful-fs. Worse, if another module depends on decompress-zip, and I depend on that module, I now am (possibly unknowingly) monkey patching fs.

ctalkington commented 10 years ago

agree with this. there are alternatives for EMFILE that have less impact on globals such as wrapping in a lazystream.

sheerun commented 10 years ago

Maybe give developers an option to disable graceful-fs.

I think it should be enabled for bower installations.

On Monday, June 2, 2014, Chris Talkington notifications@github.com wrote:

agree with this. there are alternatives for EMFILE that have less impact on globals such as wrapping in a lazystream.

— Reply to this email directly or view it on GitHub https://github.com/bower/decompress-zip/issues/27#issuecomment-44794821.

andrewrk commented 10 years ago

I think it should be enabled for bower installations.

Then the bower app itself should require graceful fs. However note that it changed recently, a la this conversation: https://github.com/isaacs/node-graceful-fs/commit/08471b246bec73848b53e9ad4972f5fe02031805

wibblymat commented 10 years ago

I'm happy to upgrade to graceful-fs 3.0

wibblymat commented 10 years ago

Fixed in 0.0.8 (@a282e096a4284f029b05a23469cef1db0d3ddc23)