Allow for maximum stripping (strip=2 in tests)

bower / decompress-zip

Module that decompresses zip files

MIT License

102 stars 76 forks source link

Allow for maximum stripping (strip=2 in tests) #42

Closed sdumetz closed 8 years ago

sdumetz commented 9 years ago

There was a bug when attempting to strip max number of folders. This fix works for me and seems to be OK generally.

coveralls commented 9 years ago

Coverage increased (+0.87%) when pulling 3ad4436665532a7c2ddb89902eeebede5358078b on klepthys:master into 55ac1e7e5fd98f00176c4951a515bfdc417280fd on bower:master.

sindresorhus commented 9 years ago

Will accept the test if you remove the other changes, but the fix isn't the right way to solve it.

sdumetz commented 9 years ago

What do you think would be the right way? I know that's just a quick fix that works for me, and I'm willing to do something a bit cleaner if you want some help with this issue. otherwise, I'll just submit the test alone and let you implement the fix your own way.

sindresorhus commented 9 years ago

What do you think would be the right way?

I don't have time to look into that right now.