bower / decompress-zip

Module that decompresses zip files
MIT License
102 stars 76 forks source link

Having trouble unzipping mac app (atom shell) #43

Open reggi opened 9 years ago

reggi commented 9 years ago

I'm attempting to unzip the darwin mac app for atom shell .

I've tried a ton of npm modules as well as issued some bugs but no response.

Every time I try to unzip the atom shell app with node / programmatically I get this error.

screen shot 2015-01-15 at 12 35 34 pm

I opened up mac Console and can see it logs the following when I try to run:

1/21/15 4:02:11.440 PM com.apple.xpc.launchd[1]: (com.github.atom-shell.255064[19701]) Could not find and/or execute program specified by service: 13: Permission denied: /Users/thomas/Desktop/wallpaper/wallpaper-app/build/Atom.app/Contents/MacOS/Atom
1/21/15 4:02:11.440 PM com.apple.xpc.launchd[1]: (com.github.atom-shell.255064[19701]) Service setup event to handle failure and will not launch until it fires.
1/21/15 4:02:11.440 PM Finder[339]: spawn_via_launchd() failed, errno=111 label=com.github.atom-shell.255064 path=/Users/thomas/Desktop/wallpaper/wallpaper-app/build/Atom.app/Contents/MacOS/Atom flags=1 : LaunchApplicationClient.cp #1136 LaunchApplicationViaLaunchDJobLabel() q=com.apple.root.default-qos
1/21/15 4:02:11.440 PM Finder[339]: spawn_via_launchd() failed, errno=111 label=com.github.atom-shell.255064 path=/Users/thomas/Desktop/wallpaper/wallpaper-app/build/Atom.app/Contents/MacOS/Atom flags=1

I was really happy to see that this library had support for symlinks, and it seems to look as it they are working working. However the app still won't open. Thoughts?

sindresorhus commented 9 years ago

The problem is that none of these unzip libs preserve the executive permissions.

Similar issue with workaround: https://github.com/sindresorhus/gulp-zip/issues/38

reggi commented 9 years ago

I created a diff repo between output from ls -laR for extracted versions of atom-shell with decompress-zip and archive utility. Could be useful in understand things better.

https://github.com/reggi/atom-shell-ls-zip-diff/commit/fa7930029300bc3859795fcf65afeba148e218fa?diff=split

szwacz commented 9 years ago

Same issue led me to this PR: https://github.com/bower/decompress-zip/pull/32 So I believe we are almost having first decompressor which preserves file permissions.

reggi commented 9 years ago

@szwacz Thats amazing! Really excited!

brian-mann commented 9 years ago

@reggi did you find any module that works?

reggi commented 9 years ago

@brian-mann Sorry I don't remember where I last left off.

reggi commented 9 years ago

@brian-mann I think the root of my particular issue was codesigning.