bower / decompress-zip

Module that decompresses zip files
MIT License
102 stars 76 forks source link

upgrade graceful-fs to 4.1.3 #53

Closed thefourtheye closed 8 years ago

thefourtheye commented 8 years ago

fixes: https://github.com/bower/decompress-zip/issues/52

develar commented 8 years ago

+1 Please accept pull request.

ungoldman commented 8 years ago
npm WARN  graceful-fs@3.0.8: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible.

This is an underlying dependency for electron-packager, hoping to fix this issue up the chain from here.

electron-packager@5.2.1
├ asar@0.8.3
└─┬ mksnapshot@0.1.0
  └─┬ decompress-zip@0.1.0
    └─ graceful-fs@3.0.8
zeke commented 8 years ago

This is an underlying dependency for electron-packager, hoping to fix this issue up the chain from here.

Same here. cc @wibblymat and @sindresorhus

benmann commented 8 years ago

cc @sheerun

sheerun commented 8 years ago

@thefourtheye @zeke @ungoldman @develar What are the braking changes for graceful-fs 4.x?

thefourtheye commented 8 years ago

@sheerun As far as I know there is nothing. Before v4 this was the actual problem with graceful-fs. In 4.0 it was fixed in a backward compatible manner.

sheerun commented 8 years ago

Well, I don't want to guess.. You want half of the community to do major upgrade of graceful-fs, but there isn't even a changelog available: https://github.com/isaacs/node-graceful-fs/issues/51

zeke commented 8 years ago

Maybe @isaacs can shed some :bulb: on the matter...

sheerun commented 8 years ago

released as 0.2.1

zeke commented 8 years ago

Thank you, @sheerun!