bower / registry

The Bower registry
https://registry.bower.io/packages
MIT License
292 stars 66 forks source link

Fix Unregistration of transfered repos #116

Closed samccone closed 9 years ago

samccone commented 9 years ago

Steps to reproduce

This is because of

var owner = pathParts[1];
var repo = path.basename(pathParts[2], '.git');

https://github.com/samccone/registry/blob/master/lib/routes/packages.js#L43-L44

Which pulls the contributors from the original registration url instead of the updated location of the project (since it has been moved).

screen shot 2015-02-25 at 1 53 13 pm

Solution

For instance:

curl -I https://github.com/marionettejs/testing
HTTP/1.1 301 Moved Permanently
Server: GitHub.com
Location: https://github.com/samccone/testing

Clearly the permissions should be checked against samccone/testing


These are just my thoughts after chatting with @desandro, let me know If I am missing something or whatnot. :+1:

The ultimate goal here is to unburden the people that have been doing a great job manually doing the unregistration over at https://github.com/bower/bower/issues/120

desandro commented 9 years ago

:+1:

samccone commented 9 years ago

welp there we are thanks @sheerun was going to work on this on Friday, been out on site consulting this week so time has been at a minimum thanks for doing it!

sheerun commented 9 years ago

thanks for research!