search

bower / registry

The Bower registry
https://registry.bower.io/packages
MIT License
292 stars 66 forks source link

Improve error reporting and package removal functionality #67

Closed jamesreggio closed 10 years ago

jamesreggio commented 10 years ago

The horribleness of bower/bower#120 led me into this repo, where I realized that the 403 Forbidden responses that everybody kept seeing were inaccurate: the problem was a bad argument, and the status should've been a 400.

I combed through packages.js, where I enhanced the error reporting and generally cleaned up the logic. I also pulled in the changes from bower/registry#58, which were reasonable and should've been merged.

Because I'm not a member of the Bower 'in' crowd, I don't really have the means to test these changes (I don't have the time to setup a mock database with a reverse-engineered copy of the schema). Perhaps somebody could pull these down and run a basic smoke test?

jamesreggio commented 10 years ago

@desandro, perhaps you can help me get the right pair of eyes on this?

desandro commented 10 years ago

This is tremendous work! Thank you so much for your contribution!

This LGTM :thumbsup: . Ping @wibblymat Can you take a look?

sheerun commented 10 years ago

lgtm2