add package name validation

bower / registry

The Bower registry

https://registry.bower.io/packages

MIT License

292 stars 66 forks source link

add package name validation #76

Closed patrickkettner closed 10 years ago

patrickkettner commented 10 years ago

fixes #59

benschwarz commented 10 years ago

Whoa @patrickkettner, thats awesome. If you renamed all the good variables to valid, then I reckon we could merge this.

patrickkettner commented 10 years ago

doneski

benschwarz commented 10 years ago

Thanks @patrickkettner !

rayshan commented 10 years ago

Sorry @patrickkettner I'm late to this party, is it possible for you to add a comment explaining what your validation regex does (I know it's simple but just for documentation purposes)? Also is it possible for you to add a test for unicode characters?

patrickkettner commented 10 years ago

More than happy to add a note explaining, however I didn't think unicode was a supported name - @sindresorhus ?

rayshan commented 10 years ago

You're correct. I meant to say a test that verifies unicode isn't supported.

For the comment maybe just say please refer to https://github.com/bower/bower.json-spec#name so we don't need to duplicate documentation.

patrickkettner commented 10 years ago

ah, ok.

done