search

bower / registry

The Bower registry
https://registry.bower.io/packages
MIT License
292 stars 66 forks source link

Add CORS support #77

Closed patrickkettner closed 10 years ago

patrickkettner commented 10 years ago

fixes #74

rayshan commented 10 years ago

Thank you for the PR and tests Patrick. Had a few questions, will in-line.

rayshan commented 10 years ago

Thank you sir. LGTM but I don't have write access so I'll defer to another contributor.

wibblymat commented 10 years ago

Thanks!

kentwills commented 10 years ago

registry server headers should support CORS headers: Uncaught AssertionError: expected undefined to exist

build broken

patrickkettner commented 10 years ago

Where are you seeing this? The PR and the merged build pass the test

kentwills commented 10 years ago

local build, investigating.

patrickkettner commented 10 years ago

@kentwills - any idea what happened?

kentwills commented 10 years ago

@patrickkettner just realized it was as simple as the port was in use. https://paste.lugons.org/show/B5PM2R52xrJTujnkEBj7/, the current error message is rather poor.

patrickkettner commented 10 years ago

hah - that is an awful err message. sounds like another PR is needed :]