add support for registering http and ssh based urls

patrickkettner commented 10 years ago

fixes #4

kentwills commented 10 years ago

This is a feature we would like to have at Yelp. Is this an acceptable pull request? Can someone please merge this?

wibblymat commented 10 years ago

Since you check the availability of the repo from the server, LGTM.

patrickkettner commented 10 years ago

Yay! Thanks @wibblymat.

Do you know when we can redeploy to heroku?

kentwills commented 10 years ago

registry server routes should support /status: Uncaught AssertionError: expected 200 to equal 404

Build fail

patrickkettner commented 10 years ago

yikes, that sounds sound good. Where are you getting these results, @kentwills? Pulling down master onto a vanilla vm results in passing tests for me

kentwills commented 10 years ago

failing under node v0.10.17, bumping the version to see if it is an issue.

patrickkettner commented 10 years ago

Working on my 0.10.17, for what its worth

> bower-registry@0.1.1 test /private/tmp/registry
> gulp

[14:54:28] Using gulpfile /private/tmp/registry/gulpfile.js
[14:54:28] Starting 'lint'...
[14:54:28] Finished 'lint' after 8.66 ms
[14:54:28] Starting 'test'...
[14:54:28] Finished 'test' after 6.11 ms
[14:54:28] Starting 'default'...
[14:54:28] Finished 'default' after 6.71 μs

  Some test suite
    ✓ has some tests 

  package names
    ✓ should support simple names 
    ✓ should allow dots 
    ✓ should allow dashes 
    ✓ should allow underscores 
    ✓ should not allow consecutive dots 
    ✓ should not allow consecutive dashes 
    ✓ should not allow consecutive underscores 
    ✓ should not allow dots at the begining 
    ✓ should not allow dots at the end 
    ✓ should not allow dashes at the begining 
    ✓ should not allow dashes at the end 
    ✓ should not allow underscores at the begining 
    ✓ should not allow underscores at the end 
    ✓ should not allow uppercase letters 
    ✓ should not allow names longer than 50 chars  

  registry server
    headers
      ✓ should support CORS headers 

  registry server
    routes
      ✓ should support /status 

  18 passing (960ms)

 WM  registry git:(master) node --version
v0.10.17

rayshan commented 10 years ago

Maybe the server isn't listening?

https://travis-ci.org/bower/registry#L947

  registry server
    routes
  ✓ should support /status 
  17 passing (3s)
  1 failing
  1) registry server "before all" hook:
     Error: timeout of 2000ms exceeded
      at null.<anonymous> (/home/travis/build/bower/registry/node_modules/gulp-mocha/node_modules/mocha/lib/runnable.js:139:19)
      at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
events.js:72
        throw er; // Unhandled 'error' event
              ^
Error in plugin 'gulp-mocha'
1 test failed.
    at Transform.<anonymous> (/home/travis/build/bower/registry/node_modules/gulp-mocha/index.js:23:25)
    at Runner.<anonymous> (/home/travis/build/bower/registry/node_modules/gulp-mocha/node_modules/mocha/lib/runner.js:576:5)
    at Runner.EventEmitter.emit (events.js:117:20)
    at /home/travis/build/bower/registry/node_modules/gulp-mocha/node_modules/mocha/lib/runner.js:583:10
    at /home/travis/build/bower/registry/node_modules/gulp-mocha/node_modules/mocha/lib/runner.js:517:7
    at next (/home/travis/build/bower/registry/node_modules/gulp-mocha/node_modules/mocha/lib/runner.js:246:23)
    at Object._onImmediate (/home/travis/build/bower/registry/node_modules/gulp-mocha/node_modules/mocha/lib/runner.js:275:5)
    at processImmediate [as _immediateCallback] (timers.js:330:15)
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0
The command "npm test" exited with 1.

patrickkettner commented 10 years ago

@kentwills - any idea what happened?

bower / registry

add support for registering http and ssh based urls #78