search

bowers-illinois-edu / bowershansen-CI-course

Source files for Jake and Ben and Tom's causal inference course materials
5 stars 6 forks source link

Simplify coffee data read in #1

Closed jabranham closed 9 years ago

jabranham commented 9 years ago

People get confused when they have variables both inside and outside a data.frame object (here y and z). Suggestion to use intuitive c() function to simplify this. Added benefit of dropping a now-unnecessary footnote.

benthestatistician commented 9 years ago

I agree that c() is more intuitive. On the other hand, in my experience using it for data entry is more error prone than using scan(nlines=1), due to the need to alternative between typing data and typing commas. For this reason I'm going to keep that code here.

Adding the c() version might make sense, as an addition. I'll hold off on that for the moment, in part b/c you seem to prefer a shorter version w/o footnote. Submit a revised merge request incorporating this if you like.

Thanks for the suggestion in any event.